Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TST] Test CLASSY class, not classy function #564

Merged
merged 3 commits into from
Jul 1, 2022
Merged

[TST] Test CLASSY class, not classy function #564

merged 3 commits into from
Jul 1, 2022

Conversation

itrharrison
Copy link
Contributor

Description

Merging will close #563

This changes the test to be on the CLASSY class, rather than the to-be-deleted function.

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@itrharrison itrharrison self-assigned this Jul 1, 2022
@itrharrison itrharrison changed the base branch from main to module/power_spectrum July 1, 2022 13:57
@rrjbca rrjbca marked this pull request as ready for review July 1, 2022 14:37
@rrjbca rrjbca self-requested a review July 1, 2022 15:02
rrjbca
rrjbca approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@rrjbca rrjbca left a comment •
edited by itrharrison
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to consider unit tests more carefully in the future, see #567

@rrjbca rrjbca merged commit ab189c9 into skypyproject:module/power_spectrum Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrjbca rrjbca rrjbca approved these changes

Assignees

@itrharrison itrharrison

Labels
module: power spectrum tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TST: Test classy power spectrum class, rather than (to be deleted) function
2 participants
@itrharrison @rrjbca